Skip to content

fix(query builder): correct edge cases and typing of query builder #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Nov 25, 2025
Merged

fix(query builder): correct edge cases and typing of query builder #250

merged 37 commits into from
Nov 25, 2025

Conversation

@euri10
Copy link
Collaborator

@euri10 euri10 commented Nov 17, 2025

@euri10
Copy link
Collaborator Author

euri10 commented Nov 17, 2025

it's weird @cofin i get test failures locally but not in ci, 1st time i see this 🤣

>           raise sqlspec.exceptions.SQLSpecError(msg)
E           sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [email, name], received [1, 2].

sqlspec/core/parameters/_alignment.py:229: SQLSpecError

 docs/examples/usage/usage_query_builder_9.py ⨯                                                                                                                                                          100% ██████████
=============================================================================================== short test summary info ================================================================================================
FAILED docs/examples/usage/usage_query_builder_10.py::test_example_10 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [email, email_1, email_2, name, name_1, name_2], received [1, 2, 3, 4, 5, 6].
FAILED docs/examples/usage/usage_query_builder_12.py::test_example_12 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [2, email], received [1, 2].
FAILED docs/examples/usage/usage_query_builder_13.py::test_example_13 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: 3 parameters provided but 4 placeholders detected.
FAILED docs/examples/usage/usage_query_builder_14.py::test_example_14 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [4, email, name, status], received [1, 2, 3, 4].
FAILED docs/examples/usage/usage_query_builder_17.py::test_example_17 - sqlspec.exceptions.SQLSpecError: SQLite database error: table users already exists
FAILED docs/examples/usage/usage_query_builder_19.py::test_example_19 - AttributeError: 'CreateIndex' object has no attribute 'table'
FAILED docs/examples/usage/usage_query_builder_22.py::test_example_22 - sqlspec.exceptions.SQLParsingError: SQLite SQL syntax error : near "SELECT": syntax error
FAILED docs/examples/usage/usage_query_builder_24.py::test_example_24 - ValueError: No result found, exactly one row expected
FAILED docs/examples/usage/usage_query_builder_31.py::test_example_31 - sqlspec.exceptions.SQLSpecError: SQLite database error: unrecognized token: "@"
FAILED docs/examples/usage/usage_query_builder_32.py::test_example_32 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: 3 parameters provided but 2 placeholders detected.
FAILED docs/examples/usage/usage_query_builder_9.py::test_example_9 - sqlspec.exceptions.SQLSpecError: Parameter count mismatch: expected identifiers [email, name], received [1, 2].

Results (4.38s):
      69 passed
      11 failed
         - docs/examples/usage/usage_query_builder_10.py:6 test_example_10
         - docs/examples/usage/usage_query_builder_12.py:6 test_example_12
         - docs/examples/usage/usage_query_builder_13.py:6 test_example_13
         - docs/examples/usage/usage_query_builder_14.py:7 test_example_14
         - docs/examples/usage/usage_query_builder_17.py:6 test_example_17
         - docs/examples/usage/usage_query_builder_19.py:6 test_example_19
         - docs/examples/usage/usage_query_builder_22.py:6 test_example_22
         - docs/examples/usage/usage_query_builder_24.py:7 test_example_24
         - docs/examples/usage/usage_query_builder_31.py:6 test_example_31
         - docs/examples/usage/usage_query_builder_32.py:6 test_example_32
         - docs/examples/usage/usage_query_builder_9.py:6 test_example_9
  ~/PycharmProjects/sqlspec on   169_usage_query_builder ❯

other than that the docs looks ok to me

@euri10 euri10 marked this pull request as ready for review November 17, 2025 19:56
@euri10 euri10 changed the title feat(docs): usage query builder docs: usage query builder Nov 18, 2025
euri10
euri10 commented Nov 18, 2025
View reviewed changes
@euri10
Copy link
Collaborator Author

euri10 commented Nov 18, 2025

@cofin i fixed the failing tests i could, I dont get the failure on quickstart_4 (unrelated to this pr but test amples werent tested previously in ci) as it passes locally fine and lgtm
for the others related to the pr ie the query_builder one can you take a look please ?

@cofin cofin force-pushed the 169_usage_query_builder branch from b8cd8fc to 064db00 Compare November 18, 2025 14:56
euri10 added 10 commits November 18, 2025 13:38
@euri10 @cofin
feat(docs): add :caption: to all literalinclude directives in query_b…
99124ee 
…uilder.rst

- Each literalinclude now has a :caption: matching its section or subsection, wrapped in backticks
- Improves clarity and navigation for code examples in the documentation
- All Python examples are now referenced with contextual captions
@euri10 @cofin
update tests
bb2b309
@euri10 @cofin
all examples show well
fc47d47
@euri10 @cofin
lint
e508626
@euri10 @cofin
lint
cf8e9dc
@euri10 @cofin
attempt at running docs tests in ci, some should fail
eee5f2f
@euri10 @cofin
close the pool
038b49d
@euri10 @cofin
fix quickstart failure
c287d78
@euri10 @cofin
weird error
f981463
@euri10 @cofin
trying something
687d0be
@cofin cofin force-pushed the 169_usage_query_builder branch from 064db00 to 687d0be Compare November 18, 2025 19:38
@cofin cofin changed the title docs: usage query builder fix(query builder): correct edge cases and typing of query builder Nov 23, 2025
cofin added 15 commits November 23, 2025 19:34
@cofin
fix: refine table name extraction in MERGE INTO clause handling
9cd3731
@cofin
fix: update type alias for AiosqlParamType and improve import handling
be547de
@cofin
fix: update example usage for SQLResult and schema mapping, enhance q…
9ca1013 
…uery builder examples
@cofin
fix: enhance pgvector error handling in asyncpg and psycopg type hand…
03e4242 
…lers
@cofin
fix: update SQL syntax in test for handling duplicate keys in MySQL
b28abeb
@cofin
fix: ensure pytest is grouped for portal tests
e9715e0
@cofin
fix: enhance pytest configuration with fault handler and timeout
87900b1
@cofin
fix: enhance logging filter to suppress additional benign sqlglot war…
0e225b1 
…nings

fix: streamline cleanup process in asyncmy tests by removing exception handling
@cofin
fix: ensure tables are created with "IF NOT EXISTS" in asyncmy tests
503d94f
@cofin
fix: enhance logging filter to cover additional sqlglot loggers and s…
c4d52e6 
…ilence MySQL notes during fixture cleanup
@cofin
fix: correct metadata reference in advanced SQL object test
de9f559
@cofin
fix: add pytest xdist group for PostgreSQL in multiple example files
decae64
@cofin
fix: update xdist group from "storage" to "postgres" in storage bridg…
c870455 
…e tests
@cofin
chore: trim the AGENTS.md
57ccf12
@cofin
fix: add pytest-timeout dependency and update related configurations
da6e5f5
@cofin cofin merged commit 86cc802 into litestar-org:main Nov 25, 2025
15 checks passed
@euri10 euri10 deleted the 169_usage_query_builder branch November 25, 2025 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

docs: test ./usage/query_builder.rst

2 participants

@euri10 @cofin